amoghrajesh commented on code in PR #44186:
URL: https://github.com/apache/airflow/pull/44186#discussion_r1848390227
##########
task_sdk/tests/execution_time/test_supervisor.py:
##########
@@ -51,30 +51,30 @@ def test_reading_from_pipes(self, captured_logs,
time_machine):
# Ignore anything lower than INFO for this test. Captured_logs resets
things for us afterwards
structlog.configure(wrapper_class=structlog.make_filtering_bound_logger(logging.INFO))
- line = lineno()
-
def subprocess_main():
# This is run in the subprocess!
# Ensure we follow the "protocol" and get the startup message
before we do anything
sys.stdin.readline()
- # Flush calls are to ensure ordering of output for predictable
tests
import logging
import warnings
print("I'm a short message")
sys.stdout.write("Message ")
- sys.stdout.write("split across two writes\n")
- sys.stdout.flush()
-
print("stderr message", file=sys.stderr)
- sys.stderr.flush()
+ # We need a short sleep for the main process to process things. I
worry this timining will be
Review Comment:
```suggestion
# We need a short sleep for the main process to process things.
I worry this timing will be
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
