potiuk commented on code in PR #44172:
URL: https://github.com/apache/airflow/pull/44172#discussion_r1848939655
##########
dev/breeze/src/airflow_breeze/utils/selective_checks.py:
##########
@@ -1473,10 +1497,11 @@ def _find_all_providers_affected(self, include_docs:
bool) -> list[str] | AllPro
)
if not all_providers:
return None
- for provider in list(all_providers):
- all_providers.update(
- get_related_providers(provider, upstream_dependencies=True,
downstream_dependencies=True)
- )
+ if not all_providers == {OPENLINEAGE_INTEGRATION}:
Review Comment:
I am not sure if this is right. This ia bit of magical why it happens. Why
we should not add "related" providers when only "openlineage" is changed?
I would say that maybe it's not worth to make this exclusion - this seems
reasonable to also run the tests that are related to openlineage - because
let's asume there are some "google" changes that use openlineage provider and
THOSE tests are checking something about generated assets. This is merely
optimisation (i.e. "let's only run tests that are likely to be affected") so
other than running a bit more tests when you modify assets, there is not much
harm (and can avoid some false positives).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
