sunank200 commented on code in PR #42404:
URL: https://github.com/apache/airflow/pull/42404#discussion_r1849884843
##########
airflow/cli/commands/task_command.py:
##########
@@ -91,19 +91,54 @@ def _generate_temporary_run_id() -> str:
return f"__airflow_temporary_run_{timezone.utcnow().isoformat()}__"
+def _fetch_dag_run_from_run_id_or_logical_date_string(
+ *,
+ dag_id: str,
+ value: str,
Review Comment:
The doc-string has description for value.
##########
airflow/models/dag.py:
##########
@@ -1700,8 +1664,8 @@ def create_dagrun(
self,
state: DagRunState,
*,
- triggered_by: DagRunTriggeredByType,
- execution_date: datetime | None = None,
+ triggered_by: DagRunTriggeredByType | None = None,
Review Comment:
Changed it
##########
tests/models/test_dag.py:
##########
@@ -2671,8 +2663,8 @@ def get_ti_from_db(task):
# task_2 remains as SUCCESS
assert get_ti_from_db(task_2).state == State.SUCCESS
# task_3 and task_4 are cleared because they were in
FAILED/UPSTREAM_FAILED state
- assert get_ti_from_db(task_3).state == State.NONE
- assert get_ti_from_db(task_4).state == State.NONE
+ assert get_ti_from_db(task_3).state == State.UPSTREAM_FAILED
Review Comment:
Fixed it.
##########
tests/www/views/test_views.py:
##########
@@ -396,8 +396,8 @@ def get_task_instance(session, task):
# task_2 remains as SUCCESS
assert get_task_instance(session, task_2).state == State.SUCCESS
# task_3 and task_4 are cleared because they were in
FAILED/UPSTREAM_FAILED state
- assert get_task_instance(session, task_3).state == State.NONE
- assert get_task_instance(session, task_4).state == State.NONE
+ assert get_task_instance(session, task_3).state ==
State.UPSTREAM_FAILED
+ assert get_task_instance(session, task_4).state == State.FAILED
Review Comment:
Fixed it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
