Lee-W commented on code in PR #44226:
URL: https://github.com/apache/airflow/pull/44226#discussion_r1851449252
##########
airflow/api_fastapi/core_api/routes/public/dags.py:
##########
@@ -126,8 +128,10 @@ def get_dag_tags(
limit=limit,
session=session,
)
+ if TYPE_CHECKING:
+ assert total_entries is not None
dag_tags = session.execute(dag_tags_select).scalars().all()
- return DAGTagCollectionResponse(tags=[dag_tag for dag_tag in dag_tags],
total_entries=total_entries)
+ return DAGTagCollectionResponse(tags=[x for x in dag_tags],
total_entries=total_entries)
Review Comment:
not sure why we change this 🤔 the original one looks better to me
##########
airflow/api_fastapi/core_api/routes/public/dags.py:
##########
@@ -274,7 +281,7 @@ def patch_dags(
)
return DAGCollectionResponse(
- dags=[DAGResponse.model_validate(dag, from_attributes=True) for dag in
dags],
+ dags=[DAGResponse.model_validate(x, from_attributes=True) for x in
dags],
Review Comment:
same here
##########
airflow/api_fastapi/core_api/routes/public/event_logs.py:
##########
@@ -126,21 +126,17 @@ def get_event_logs(
base_select = base_select.where(Log.dttm > after)
event_logs_select, total_entries = paginated_select(
base_select,
- [],
+ None,
Review Comment:
We probably could use keyword argment here like the change in
`airflow/api_fastapi/core_api/routes/public/connections.py`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
