ashb commented on code in PR #44229:
URL: https://github.com/apache/airflow/pull/44229#discussion_r1851888486
##########
task_sdk/tests/execution_time/test_supervisor.py:
##########
@@ -225,3 +225,86 @@ def test_run_simple_dag(self, test_dags_dir,
captured_logs, time_machine):
"logger": "task",
"timestamp": "2024-11-07T12:34:56.078901Z",
} in captured_logs
+
+
+class TestHandleRequest:
+ @pytest.fixture
+ def watched_subprocess(self, mocker):
+ """Fixture to provide a WatchedSubprocess instance."""
+ return WatchedSubprocess(
+ ti_id=uuid7(),
+ pid=12345,
+ stdin=mocker.Mock(), # Not used in these tests
+ stdout=mocker.Mock(), # Not used in these tests
+ stderr=mocker.Mock(), # Not used in these tests
+ client=mocker.Mock(),
+ process=mocker.Mock(),
+ )
+
+ @pytest.mark.parametrize(
+ "message, expected_buffer, client_attr_path, method_arg,
mock_response",
Review Comment:
I'm guessing it only supported the csv version first and they added the
other later then just never changed the docs.
Consistency, and it feels better/more explicit to not rely on splitting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
