rawwar commented on code in PR #44238: URL: https://github.com/apache/airflow/pull/44238#discussion_r1851990971
########## airflow/api_fastapi/core_api/routes/public/log.py: ########## @@ -0,0 +1,126 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from __future__ import annotations + +from typing import Annotated, Any + +from fastapi import Depends, HTTPException, Request, Response, status +from itsdangerous import BadSignature, URLSafeSerializer +from sqlalchemy.orm import Session, joinedload +from sqlalchemy.sql import select + +from airflow.api_fastapi.common.db.common import get_session +from airflow.api_fastapi.common.headers import HeaderAcceptJsonOrText +from airflow.api_fastapi.common.router import AirflowRouter +from airflow.api_fastapi.common.types import Mimetype +from airflow.api_fastapi.core_api.datamodels.log import TaskInstancesLogResponse +from airflow.api_fastapi.core_api.openapi.exceptions import create_openapi_http_exception_doc +from airflow.exceptions import TaskNotFound +from airflow.models import TaskInstance, Trigger +from airflow.models.taskinstancehistory import TaskInstanceHistory +from airflow.utils.log.log_reader import TaskLogReader + +task_instances_log_router = AirflowRouter( + tags=["Task Instance"], prefix="/dags/{dag_id}/dagRuns/{dag_run_id}/taskInstances" +) + + +@task_instances_log_router.get( + "/{task_id}/logs/{task_try_number}", + responses=create_openapi_http_exception_doc([status.HTTP_404_NOT_FOUND]), + response_model=TaskInstancesLogResponse, +) +def get_log( + dag_id: str, + dag_run_id: str, + task_id: str, + task_try_number: int, + accept: HeaderAcceptJsonOrText, + request: Request, + session: Annotated[Session, Depends(get_session)], + full_content: bool = False, + map_index: int = -1, + token: str | None = None, +): + """Get logs for a specific task instance.""" + if not token: + metadata = {} + else: + try: + metadata = URLSafeSerializer(request.app.state.secret_key).loads(token) + except BadSignature: + raise HTTPException( + status.HTTP_400_BAD_REQUEST, "Bad Signature. Please use only the tokens provided by the API." + ) + + if metadata.get("download_logs") and metadata["download_logs"]: + full_content = True + + if full_content: + metadata["download_logs"] = True + else: + metadata["download_logs"] = False + + task_log_reader = TaskLogReader() + + if not task_log_reader.supports_read: + raise HTTPException(status.HTTP_400_BAD_REQUEST, "Task log handler does not support read logs.") + + query = ( + select(TaskInstance) + .where( + TaskInstance.task_id == task_id, + TaskInstance.dag_id == dag_id, + TaskInstance.run_id == dag_run_id, + TaskInstance.map_index == map_index, + ) + .join(TaskInstance.dag_run) + .options(joinedload(TaskInstance.trigger).joinedload(Trigger.triggerer_job)) + ) + ti = session.scalar(query) + if ti is None: + query = select(TaskInstanceHistory).where( + TaskInstanceHistory.task_id == task_id, + TaskInstanceHistory.dag_id == dag_id, + TaskInstanceHistory.run_id == dag_run_id, + TaskInstanceHistory.map_index == map_index, + TaskInstanceHistory.try_number == task_try_number, + ) + ti = session.scalar(query) + + if ti is None: + metadata["end_of_log"] = True + raise HTTPException(status.HTTP_404_NOT_FOUND, "TaskInstance not found") + + dag = request.app.state.dag_bag.get_dag(dag_id) + if dag: + try: + ti.task = dag.get_task(ti.task_id) + except TaskNotFound: + pass + + logs: Any + if accept == Mimetype.JSON or accept == Mimetype.ANY: # default + logs, metadata = task_log_reader.read_log_chunks(ti, task_try_number, metadata) + logs = logs[0] if task_try_number is not None else logs Review Comment: we don't allow task_try_number to be None. So, do we need to check if it's None? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
