dstandish commented on code in PR #44208:
URL: https://github.com/apache/airflow/pull/44208#discussion_r1852083861
##########
airflow/settings.py:
##########
@@ -498,7 +498,7 @@ def configure_orm(disable_connection_pool=False,
pool_class=None):
engine = create_engine(SQL_ALCHEMY_CONN, connect_args=connect_args,
**engine_args, future=True)
async_engine = create_async_engine(SQL_ALCHEMY_CONN_ASYNC, future=True)
- create_async_session = sessionmaker(
+ session_maker_async = sessionmaker(
Review Comment:
to clarify, with this
> that's how sqlalchemy docs and many other documents online recommend to do
it
you are saying that the SA docs recommend doing it by storing session
factory as AsyncSession, like we did with Session?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
