ttzhou commented on code in PR #44264:
URL: https://github.com/apache/airflow/pull/44264#discussion_r1852720763
##########
providers/src/airflow/providers/snowflake/hooks/snowflake.py:
##########
@@ -301,7 +307,13 @@ def _conn_params_to_sqlalchemy_uri(self, conn_params:
dict) -> str:
for k, v in conn_params.items()
if v
and k
- not in ["session_parameters", "insecure_mode", "private_key",
"client_request_mfa_token"]
+ not in {
Review Comment:
changed to a set; we're not iterating, may as well make it O(1)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
