omkar-foss commented on code in PR #44246:
URL: https://github.com/apache/airflow/pull/44246#discussion_r1852981306
##########
airflow/api_fastapi/core_api/routes/public/task_instances.py:
##########
@@ -64,13 +67,12 @@
from airflow.utils.db import get_query_count
from airflow.utils.state import TaskInstanceState
-task_instances_router = AirflowRouter(
- tags=["Task Instance"],
prefix="/dags/{dag_id}/dagRuns/{dag_run_id}/taskInstances"
-)
+task_instances_router = AirflowRouter(tags=["Task Instance"],
prefix="/dags/{dag_id}")
+task_instances_prefix = "/dagRuns/{dag_run_id}/taskInstances"
Review Comment:
We can make it all capitals but if we plan to do so, I suppose we'll need to
follow the same for all router variables too, for consistency.
E.g. we'll need to update `task_instances_router` to `TASK_INSTANCE_ROUTER`,
etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
