johncmerfeld commented on code in PR #43978:
URL: https://github.com/apache/airflow/pull/43978#discussion_r1853071295
##########
tests/utils/test_db.py:
##########
@@ -251,3 +258,10 @@ def test_alembic_configuration(self):
import airflow
assert config.config_file_name ==
os.path.join(os.path.dirname(airflow.__file__), "alembic.ini")
+
+ @mock.patch("sqlalchemy.orm.Session.scalar")
+ def test_bool_lazy_select_sequence(self, mock_scalar):
+ mock_scalar.return_value = None
+
+ lss = EmptyLazySelectSequence()
+ assert not bool(lss)
Review Comment:
You're right. I've fixed the test and it is now meaningful. Without the
`bool()` cast in `check_query_exists` the test fails
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
