jason810496 commented on PR #43947: URL: https://github.com/apache/airflow/pull/43947#issuecomment-2495517395
Hi @pierrejeambrun, I chose the schema with only basic functionalities defined in `common/parameters.py` but used solely in a single endpoint. The refactor will not affect the OpenAPI schema or test cases. The current differences in `v1-generated.yaml` are caused by the `Offset`, `Limit`, and `OrderBy` parameters. ### Follow-Up I noticed that `_SearchParam` could leverage the factory pattern as well. I plan to refactor this part after this PR is merged to avoid making the scope of this PR too large. ### Question For some parameter schemas like `QueryTIStateFilter`, which are only used twice in `task_instance.py`, should such parameter schemas be placed directly in `task_instance.py` rather than in `common/parameters`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
