SuccessMoses commented on code in PR #44307:
URL: https://github.com/apache/airflow/pull/44307#discussion_r1856158998
##########
providers/src/airflow/providers/apache/kafka/hooks/consume.py:
##########
@@ -36,6 +48,7 @@ def __init__(self, topics: Sequence[str],
kafka_config_id=KafkaBaseHook.default_
self.topics = topics
def _get_client(self, config) -> Consumer:
+ config["error_cb"] = error_callback
Review Comment:
you approach is more robust, but if user defined error_cb does not raise
error, the operator will succeed instead of failing. i am thinking of wrapping
the function to make it predictable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
