michaeljs-c commented on code in PR #44366:
URL: https://github.com/apache/airflow/pull/44366#discussion_r1858394027


##########
airflow/api_fastapi/core_api/routes/public/__init__.py:
##########
@@ -68,10 +68,10 @@
 authenticated_router.include_router(plugins_router)
 authenticated_router.include_router(pools_router)
 authenticated_router.include_router(providers_router)
+authenticated_router.include_router(xcom_router)
 authenticated_router.include_router(task_instances_router)
 authenticated_router.include_router(tasks_router)
 authenticated_router.include_router(variables_router)
-authenticated_router.include_router(xcom_router)

Review Comment:
   This was required due to a URL conflict with patch_task_instance endpoint:
   - patch_task_instance: `"/{task_id}/{map_index}"`
   - getEntries: `/{task_id}/getEntries`
   
   Therefore it would throw a 422 error (because it tries to use "getEntries" 
as map_index which is defined as an int).
   
   By moving xcom before task_instances, the xcom url is attempted first which 
resolves the issue, while the task instance endpoint is not affected.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to