pierrejeambrun commented on code in PR #44393:
URL: https://github.com/apache/airflow/pull/44393#discussion_r1858898436
##########
airflow/api_fastapi/common/parameters.py:
##########
@@ -239,7 +239,7 @@ def to_orm(self, select: Select) -> Select:
raise ValueError(f"Cannot set 'skip_none' to False on a
{type(self)}")
if self.value is None:
- return select
+ self.value = self.get_primary_key_string()
Review Comment:
True. This is not the only place where we do it, I will merge like this to
at least unblock main.
But I definitely keep this suggestion in mind. (Even if for now the 'PK' is
retrieved, and displayed in the documentation as a normal filter, it's just on
the developer's side that it might be more complicated to understand)
We still have some improvement to do in that area, WIP. (we are missing the
exhaustive list of possible values in the documentation at the moment too)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
