Lee-W commented on code in PR #44378:
URL: https://github.com/apache/airflow/pull/44378#discussion_r1859638308
##########
contributing-docs/16_contribution_workflow.rst:
##########
@@ -196,7 +196,9 @@ Step 4: Prepare PR
and place in either `newsfragments
<https://github.com/apache/airflow/blob/main/newsfragments>`__ for core
newsfragments,
or `chart/newsfragments
<https://github.com/apache/airflow/blob/main/chart/newsfragments>`__ for helm
chart newsfragments.
- In general newsfragments must be one line. For newsfragment type
``significant``, you may include summary and body separated by a blank line,
similar to ``git`` commit messages.
+ In general newsfragments must be one line. For newsfragment type
``significant``,
+ you should follow the template in
``newsfragments/template.significant.rst`` to include summary, body, change
type and migrations rules needed.
+ This can also be done by command ``uv tool run towncrier create --dir .
--config newsfragments/config.toml --content `cat
newsfragments/template.significant.rst```.
Review Comment:
Ah, the `cat` part is something I missed 🤦♂️
But I'm not sure about the `+.significant.rst` 🤔 If we want to do it, we
probably would like to send it to the dev list before doing it, so I'll keep
this part as it it for now. I understand the chicken-egg problem, but yep it
doesn't bother me as much. For me to list
https://github.com/apache/airflow/issues/41641, the current naming actually
helps a lot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
