potiuk commented on issue #44324: URL: https://github.com/apache/airflow/issues/44324#issuecomment-2503768422
> However, there's an error when I do the same with apache-airflow==2.9.3 Good catch. Apparently we miss compatibility class for that in "common.compat" and the sensor has no corresponding tests that would detect it in "providers/tests/standard/sensors" - the test for filesystem sensor is still in "tests/sensors" that's why our test suite did not catch it. > If that's the case, maybe we should update the documentation for it on PyPi? Nope. We want to keep 2.8+ compatibility. We should add compatibilty `StartTriggerArgs` class in "common.compat" similarly to other "after 2.8" features, and import the class from there in the sensor. I guess @eladkal - since it's not a regression and standard provider is still 0.* it's not a blocker for the release and can be fixed as a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
