potiuk commented on code in PR #44454:
URL: https://github.com/apache/airflow/pull/44454#discussion_r1862352783
##########
airflow/serialization/serialized_objects.py:
##########
@@ -764,7 +759,7 @@ def serialize(
obj = cls.serialize(v, strict=strict,
use_pydantic_models=use_pydantic_models)
d[str(k)] = obj
return cls._encode(d, type_=DAT.TASK_CONTEXT)
- elif use_pydantic_models and _ENABLE_AIP_44:
+ elif use_pydantic_models:
Review Comment:
> Isn't use_pydantic_models an artifact of AIP_44 too? Remove this entirely
in a future PR?
Oh absolutely - but it is now used to pass context to venv in Python Venv /
External so we need to replace it - I planned to do it after we remove all
internal API cals - a lot of them have type hinting using *Pydantic models so
we need to remove them first in order to remove the models - see the plan in
#44436 - it's down there at the bottom
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
