[
https://issues.apache.org/jira/browse/AIRFLOW-5543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16936136#comment-16936136
]
ASF GitHub Bot commented on AIRFLOW-5543:
-----------------------------------------
pingzh commented on pull request #6174: [AIRFLOW-5543] Fix tooltip disappears
in tree and graph view
URL: https://github.com/apache/airflow/pull/6174
when page scrolls
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-5543
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
Before: if you scroll up your page in tree view or graph view, the tooltip
will also move up and in the end disappear as it is out of the page.
Using the `d3-tip` as other pages also use `d3-tip`. After the fix with page
scrolling up:
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
UI updates
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
@KevinYang21
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Tooltip in tree view and graph view disappears after page scrolls up
> --------------------------------------------------------------------
>
> Key: AIRFLOW-5543
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5543
> Project: Apache Airflow
> Issue Type: Bug
> Components: webserver
> Affects Versions: 1.10.5
> Reporter: Ping Zhang
> Assignee: Ping Zhang
> Priority: Major
> Attachments: image-2019-09-23-12-18-51-668.png
>
>
> !image-2019-09-23-12-18-51-668.png!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
