jscheffl commented on code in PR #44525:
URL: https://github.com/apache/airflow/pull/44525#discussion_r1864795740


##########
airflow/models/variable.py:
##########
@@ -182,7 +181,6 @@ def set(
 
     @staticmethod
     @provide_session
-    @internal_api_call

Review Comment:
   I assume the change you make is the "simplest way" to remove it. 
Nevertheless one main problem of AIP-44 was that the core needed to be 
re-structured and is now a bit cluttered. Example here as well: The original 
`set()` method is just calling the internal api method `_set()`. That was just 
introduced to keep interface compatibility but have the DB access separation 
layer.
   
   Can you check how it was implemented prior AIP-44 and rather revert it to 
this state back? Means that no `_set()` but the `set()` directly carries-out 
the call and makes the DB execution.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to