kaxil commented on code in PR #44579:
URL: https://github.com/apache/airflow/pull/44579#discussion_r1866506900
##########
task_sdk/src/airflow/sdk/execution_time/supervisor.py:
##########
@@ -694,11 +684,7 @@ def cb(sock: socket):
# We could have read multiple lines in one go, yield them all
while (newline_pos := buffer.find(b"\n")) != -1:
- if TYPE_CHECKING:
- # We send in a memoryvuew, but pretend it's a bytes, as Buffer
is only in 3.12+
- line = buffer[: newline_pos + 1]
- else:
- line = memoryview(buffer)[: newline_pos + 1] # Include the
newline character
Review Comment:
There was a bug where `msg = decoder.validate_json(line)` expected bytes but
this sent `memoryview`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
