pierrejeambrun commented on code in PR #44572:
URL: https://github.com/apache/airflow/pull/44572#discussion_r1866244961


##########
airflow/api_fastapi/core_api/openapi/v1-generated.yaml:
##########
@@ -7815,11 +7811,12 @@ components:
           - join
           - sensor
           - task
-          - task_group
+          - asset_condition

Review Comment:
   Not used at the moment, but needed to remove an eslint error (non 
overlapping check on the enum value)



##########
airflow/ui/src/pages/DagsList/Dag/Graph/Graph.tsx:
##########
@@ -35,10 +36,16 @@ const nodeTypes = {
 };
 const edgeTypes = { custom: Edge };
 
-export const Graph = () => {
+export const Graph = ({ dagId }: { readonly dagId: DAGResponse["dag_id"] }) => 
{
   const { colorMode } = useColorMode();
 
   const { openGroupIds } = useOpenGroups();
+
+  const { data: graphData = { arrange: "LR", edges: [], nodes: [] } } =

Review Comment:
   Type system is not happy if I use `placeHolder` option. (Undefined is not 
type guarded, and fails later)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to