tirkarthi commented on code in PR #44604: URL: https://github.com/apache/airflow/pull/44604#discussion_r1868338193
########## airflow/ui/src/pages/DagsList/Dag/Tasks/Tasks.tsx: ########## @@ -0,0 +1,112 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { Heading, Skeleton, Box } from "@chakra-ui/react"; +import { useParams } from "react-router-dom"; + +import { + useTaskServiceGetTasks, + useTaskInstanceServiceGetTaskInstances, + useDagsServiceRecentDagRuns, +} from "openapi/queries"; +import type { + TaskResponse, + TaskInstanceResponse, +} from "openapi/requests/types.gen"; +import { DataTable } from "src/components/DataTable"; +import type { CardDef } from "src/components/DataTable/types"; +import { ErrorAlert } from "src/components/ErrorAlert"; + +import { TaskCard } from "./TaskCard"; + +const cardDef = ( + taskInstances?: Array<TaskInstanceResponse>, +): CardDef<TaskResponse> => ({ + card: ({ row }) => ( + <TaskCard + task={row} + taskInstance={ + taskInstances + ? taskInstances.filter( + (instance: TaskInstanceResponse) => + instance.task_id === row.task_id, + ) + : [] + } + /> + ), + meta: { + customSkeleton: <Skeleton height="120px" width="100%" />, + }, +}); + +export const Tasks = () => { + const { dagId } = useParams(); + const { + data, + error: TasksError, + isFetching, + isLoading, + } = useTaskServiceGetTasks({ + dagId: dagId ?? "", + }); + + // Only the latest dagrun id is needed with recent dag runs of 14 returned for filtering. + // This could be switched to the endpoint to get dag with only latest run once available. + const { data: runsData } = useDagsServiceRecentDagRuns( + { dagIdPattern: dagId ?? "" }, + undefined, + { + enabled: Boolean(dagId), + }, + ); + + const runs = + runsData?.dags.find((dagWithRuns) => dagWithRuns.dag_id === dagId) + ?.latest_dag_runs ?? []; + + // Fetch the latest dag run and get task instances since we only display last run + const { data: TaskInstancesResponse } = + useTaskInstanceServiceGetTaskInstances( + { + dagId: dagId ?? "", + dagRunId: runs[0]?.dag_run_id ?? "~", + }, + undefined, + { enabled: Boolean(runs[0]?.dag_run_id) }, + ); + + return ( + <Box> + <ErrorAlert error={TasksError} /> + <Heading my={1} size="md"> + {data ? data.total_entries : 0} Tasks + </Heading> + <DataTable + cardDef={cardDef(TaskInstancesResponse?.task_instances)} + columns={[]} + data={data ? data.tasks : []} + displayMode="card" + isFetching={isFetching} + isLoading={isLoading} + modelName="Task" + total={data ? data.total_entries : 0} // Todo : Disable pagination? Review Comment: My concern was around some dags in real world having hundred or so tasks that will increase rendering time but the current fetch dag tasks API doesn't support pagination. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
