bbovenzi commented on code in PR #44597:
URL: https://github.com/apache/airflow/pull/44597#discussion_r1868422504
##########
airflow/ui/src/pages/DagsList/Dag/Tabs.tsx:
##########
@@ -24,23 +24,26 @@ import {
useSearchParams,
} from "react-router-dom";
-import type { DAGResponse } from "openapi/requests/types.gen";
+import type { DAGDetailsResponse } from "openapi/requests/types.gen";
import { DagIcon } from "src/assets/DagIcon";
import { capitalize } from "src/utils";
+import { DagDocumentation } from "./DagDocumentation";
import { DagVizModal } from "./DagVizModal";
const tabs = ["runs", "tasks", "events", "code"];
const MODAL = "modal";
-export const DagTabs = ({ dag }: { readonly dag?: DAGResponse }) => {
+export const DagTabs = ({ dag }: { readonly dag?: DAGDetailsResponse }) => {
const { dagId } = useParams();
const [searchParams, setSearchParams] = useSearchParams();
const modal = searchParams.get(MODAL);
const isGraphOpen = modal === "graph";
+ const isDocsOpen = modal === "docs";
Review Comment:
I think dag docs can use the regular `useState` instead of url parameters.
Graph is special because it's full page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
