Lee-W commented on code in PR #44709:
URL: https://github.com/apache/airflow/pull/44709#discussion_r1872376928
##########
providers/src/airflow/providers/common/compat/assets/__init__.py:
##########
@@ -63,15 +51,13 @@
if AIRFLOW_V_2_10_PLUS:
from airflow.datasets import (
DatasetAlias as AssetAlias,
- DatasetAliasEvent as AssetAliasEvent,
Review Comment:
I doubt anyone's using it, but can we just remove this from the compact
provider 🤔 . I thought we need to keep it till min provider is set to 3.x
##########
airflow/utils/context.py:
##########
@@ -145,6 +140,15 @@ def get(self, key: str, default_conn: Any = None) -> Any:
return default_conn
[email protected]()
+class AssetAliasEvent:
+ """A represeation of asset event to be triggered by an asset alias."""
Review Comment:
Should we add a `meta: private` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
