potiuk commented on code in PR #44714:
URL: https://github.com/apache/airflow/pull/44714#discussion_r1872929270
##########
generated/provider_dependencies.json:
##########
@@ -26,7 +26,7 @@
"amazon": {
"deps": [
"PyAthena>=3.0.10",
- "apache-airflow-providers-common-compat>=1.2.1",
+ "apache-airflow-providers-common-compat>=1.3.0",
Review Comment:
Yes. This is what chicke-negg provider change enables (this feature was
especially implemented for that purpose). In case provider is "chicken-egg"
providers list it is installed from local sources instead of from PyPI when
generating "PyPI" constraints (this is what has been failing before adding it
there).
Since we are releasing the two providers together, they will appear in PyPI
at the same time. And in case we decide we do not release common-compat becasue
of an error, we will also remove the amazon provider from RC1 and release both
from RC2.
We've been releasing many dependent providers like that in the past.
##########
generated/provider_dependencies.json:
##########
@@ -26,7 +26,7 @@
"amazon": {
"deps": [
"PyAthena>=3.0.10",
- "apache-airflow-providers-common-compat>=1.2.1",
+ "apache-airflow-providers-common-compat>=1.3.0",
Review Comment:
Yes. This is what chicken-egg provider change enables (this feature was
especially implemented for that purpose). In case provider is "chicken-egg"
providers list it is installed from local sources instead of from PyPI when
generating "PyPI" constraints (this is what has been failing before adding it
there).
Since we are releasing the two providers together, they will appear in PyPI
at the same time. And in case we decide we do not release common-compat becasue
of an error, we will also remove the amazon provider from RC1 and release both
from RC2.
We've been releasing many dependent providers like that in the past.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
