jedcunningham commented on PR #43368:
URL: https://github.com/apache/airflow/pull/43368#issuecomment-2523927589

   @eladkal I'm curious, can you provide a simple example for the short circuit 
scenario you are talking about? In my experimenting, that feels like a bug on 
short circuit, not a useful feature of always.
   
   e.g. if I have this:
   
   ```python
       @task.short_circuit()
       def short():
           sleep(20)
           return False
   
       @task(trigger_rule="always")
       def hello(input):
           print(f"Hello, {input}")
   
       short() >> hello.expand(input=["world", "moon"])
   ```
   
   (Note: I added a sleep to expand the race condition a bit to make it easier 
to see the problem.)
   
   When it runs, the ALWAYS means those tasks run right away. So those hello 
tasks have run before the short task finishes:
   ![Screenshot 2024-12-06 at 11 34 13 
AM](https://github.com/user-attachments/assets/21005027-dbaa-438c-a9df-8e5df1030da9)
   
   Then, when short eventually finishes, it goes in and retroactively skips... 
but thats wrong, those have already run!
   ![Screenshot 2024-12-06 at 11 36 24 
AM](https://github.com/user-attachments/assets/86fa3afd-0511-4acc-b041-95b52b112cdc)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to