shahar1 commented on code in PR #44750: URL: https://github.com/apache/airflow/pull/44750#discussion_r1874341845
########## contributing-docs/testing/unit_tests.rst: ########## @@ -459,7 +459,7 @@ Problems with Non-DB test collection ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Sometimes, even if whole module is marked as ``@pytest.mark.db_test`` even parsing the file and collecting Review Comment: ```suggestion Sometimes, even if whole module is marked as ``@pytest.mark.db_test``, parsing the file and collecting ``` ########## contributing-docs/testing/unit_tests.rst: ########## @@ -338,7 +338,7 @@ If your test accesses the database but is not marked properly the Non-DB test in How to verify if DB test is correctly classified ................................................ -When you add if you want to see if your DB test is correctly classified, you can run the test or group +If you want to see if your DB test is correctly classified, you can run the test or group of tests with ``--skip-db-tests`` flag. You can run the all (or subset of) test types if you want to make sure all ot the problems are fixed Review Comment: That's certainly an `of` :) ########## contributing-docs/testing/unit_tests.rst: ########## @@ -459,7 +459,7 @@ Problems with Non-DB test collection ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Sometimes, even if whole module is marked as ``@pytest.mark.db_test`` even parsing the file and collecting -tests will fail when ``--skip-db-tests`` is used because some of the imports od objects created in the +tests will fail when ``--skip-db-tests`` is used because some of the imports or objects created in the Review Comment: I'd go with `of` ########## contributing-docs/testing/unit_tests.rst: ########## @@ -338,7 +338,7 @@ If your test accesses the database but is not marked properly the Non-DB test in How to verify if DB test is correctly classified ................................................ -When you add if you want to see if your DB test is correctly classified, you can run the test or group +If you want to see if your DB test is correctly classified, you can run the test or group of tests with ``--skip-db-tests`` flag. You can run the all (or subset of) test types if you want to make sure all ot the problems are fixed Review Comment: ```suggestion You can run the all (or subset of) test types if you want to make sure all of the problems are fixed ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
