ashb commented on code in PR #44767:
URL: https://github.com/apache/airflow/pull/44767#discussion_r1874528110
##########
task_sdk/tests/execution_time/test_supervisor.py:
##########
@@ -349,11 +349,14 @@ def test_state_conflict_on_heartbeat(self, captured_logs,
monkeypatch, mocker):
"""
import airflow.sdk.execution_time.supervisor
- monkeypatch.setattr(airflow.sdk.execution_time.supervisor,
"MIN_HEARTBEAT_INTERVAL", 0.1)
+ # Heartbeat every time around the loop
+ monkeypatch.setattr(airflow.sdk.execution_time.supervisor,
"MIN_HEARTBEAT_INTERVAL", 0.0)
Review Comment:
This setting caused it to hit three requests every time before the fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
