ashb commented on code in PR #44687:
URL: https://github.com/apache/airflow/pull/44687#discussion_r1875063334
##########
airflow/models/renderedtifields.py:
##########
@@ -95,6 +97,12 @@ class RenderedTaskInstanceFields(TaskInstanceDependencies):
name="rtif_ti_fkey",
Review Comment:
This key is "wrong" now as the pk for ti is it's UUID `id` column
##########
airflow/models/renderedtifields.py:
##########
@@ -95,6 +97,12 @@ class RenderedTaskInstanceFields(TaskInstanceDependencies):
name="rtif_ti_fkey",
ondelete="CASCADE",
),
+ ForeignKeyConstraint(
+ [dag_id, run_id],
+ ["dag_run.dag_id", "dag_run.run_id"],
+ name="rtif_ti_fkey2",
Review Comment:
This key isn't to ti - it's to dagrun
##########
airflow/models/renderedtifields.py:
##########
@@ -69,6 +70,7 @@ class RenderedTaskInstanceFields(TaskInstanceDependencies):
__tablename__ = "rendered_task_instance_fields"
+ ti_id = Column(postgresql.UUID(as_uuid=True), nullable=False)
Review Comment:
This shouldn't be a db specific type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
