Lee-W commented on code in PR #44639:
URL: https://github.com/apache/airflow/pull/44639#discussion_r1875670102
##########
airflow/utils/context.py:
##########
@@ -161,54 +178,89 @@ class OutletEventAccessor:
:meta private:
"""
- raw_key: str | Asset | AssetAlias
+ key: str | BaseAssetUniqueKey
extra: dict[str, Any] = attrs.Factory(dict)
asset_alias_events: list[AssetAliasEvent] = attrs.field(factory=list)
- def add(self, asset: Asset | str, extra: dict[str, Any] | None = None) ->
None:
+ def add(self, asset: str | Asset, extra: dict[str, Any] | None = None) ->
None:
"""Add an AssetEvent to an existing Asset."""
if isinstance(asset, str):
- asset_uri = asset
- elif isinstance(asset, Asset):
- asset_uri = asset.uri
- else:
+ asset = Asset(asset)
Review Comment:
ah sorry, I think the one you mentioned is an outdated code. not sure why it
was still there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
