kacpermuda commented on code in PR #44717: URL: https://github.com/apache/airflow/pull/44717#discussion_r1878065089
########## providers/tests/trino/operators/test_trino.py: ########## @@ -1,113 +0,0 @@ -# -# Licensed to the Apache Software Foundation (ASF) under one -# or more contributor license agreements. See the NOTICE file -# distributed with this work for additional information -# regarding copyright ownership. The ASF licenses this file -# to you under the Apache License, Version 2.0 (the -# "License"); you may not use this file except in compliance -# with the License. You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, -# software distributed under the License is distributed on an -# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY -# KIND, either express or implied. See the License for the -# specific language governing permissions and limitations -# under the License. -from __future__ import annotations - -from unittest import mock - -from airflow.models.connection import Connection -from airflow.providers.common.compat.openlineage.facet import ( - Dataset, - SchemaDatasetFacet, - SchemaDatasetFacetFields, - SQLJobFacet, -) -from airflow.providers.common.sql.operators.sql import SQLExecuteQueryOperator -from airflow.providers.trino.hooks.trino import TrinoHook - -TRINO_CONN_ID = "test_trino" -TASK_ID = "test_trino_task" -TRINO_DEFAULT = "trino_default" - - -class TestTrinoOperator: - @mock.patch("airflow.providers.common.sql.operators.sql.SQLExecuteQueryOperator.get_db_hook") - def test_execute(self, mock_get_db_hook): - """Asserts that the run method is called when a TrinoOperator task is executed""" - - op = SQLExecuteQueryOperator( - task_id=TASK_ID, - sql="SELECT 1;", - conn_id=TRINO_CONN_ID, - handler=list, - ) - op.execute(None) - - mock_get_db_hook.return_value.run.assert_called_once_with( - sql="SELECT 1;", - autocommit=False, - handler=list, - parameters=None, - return_last=True, - ) - - -def test_execute_openlineage_events(): - DB_NAME = "tpch" - DB_SCHEMA_NAME = "sf1" - - class TrinoHookForTests(TrinoHook): - get_conn = mock.MagicMock(name="conn") - get_connection = mock.MagicMock() - - def get_first(self, *_): - return [f"{DB_NAME}.{DB_SCHEMA_NAME}"] - - dbapi_hook = TrinoHookForTests() - - sql = "SELECT name FROM tpch.sf1.customer LIMIT 3" - op = SQLExecuteQueryOperator(task_id="trino-operator", sql=sql, conn_id=TRINO_DEFAULT) - op._hook = dbapi_hook - rows = [ - (DB_SCHEMA_NAME, "customer", "custkey", 1, "bigint", DB_NAME), - (DB_SCHEMA_NAME, "customer", "name", 2, "varchar(25)", DB_NAME), - (DB_SCHEMA_NAME, "customer", "address", 3, "varchar(40)", DB_NAME), - (DB_SCHEMA_NAME, "customer", "nationkey", 4, "bigint", DB_NAME), - (DB_SCHEMA_NAME, "customer", "phone", 5, "varchar(15)", DB_NAME), - (DB_SCHEMA_NAME, "customer", "acctbal", 6, "double", DB_NAME), - ] - dbapi_hook.get_connection.return_value = Connection( - conn_id=TRINO_DEFAULT, - conn_type="trino", - host="trino", - port=8080, - ) - dbapi_hook.get_conn.return_value.cursor.return_value.fetchall.side_effect = [rows, []] - - lineage = op.get_openlineage_facets_on_start() - assert lineage.inputs == [ - Dataset( - namespace="trino://trino:8080", - name=f"{DB_NAME}.{DB_SCHEMA_NAME}.customer", - facets={ - "schema": SchemaDatasetFacet( - fields=[ - SchemaDatasetFacetFields(name="custkey", type="bigint"), - SchemaDatasetFacetFields(name="name", type="varchar(25)"), - SchemaDatasetFacetFields(name="address", type="varchar(40)"), - SchemaDatasetFacetFields(name="nationkey", type="bigint"), - SchemaDatasetFacetFields(name="phone", type="varchar(15)"), - SchemaDatasetFacetFields(name="acctbal", type="double"), - ] - ) - }, - ) - ] Review Comment: It was probably removed as the `operators/trino.py` file has been removed, so it makes sense that the corresponding test file is removed, but IMHO we should still keep this test in the trino provider (maybe in a differently named file). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
