eladkal commented on code in PR #44645: URL: https://github.com/apache/airflow/pull/44645#discussion_r1878085586
########## providers/src/airflow/providers/common/sql/CHANGELOG.rst: ########## @@ -25,6 +25,16 @@ Changelog --------- +main +..... + +.. warning:: + All deprecated classes, parameters and features have been removed from the Common SQL provider package. + The following breaking changes were introduced: + + * Hooks + * Remove ``_make_serializable`` method from ``DbApiHook``. Use ``_make_common_data_structure`` instead. Review Comment: I think we need more context here? To a user it might seem like we remove private internal function. I don't know what it's used for but either it's not part of the public API and we shouldn't have deprecate it to begin with or it has user impact and we need to better explain what it is? (To clarify since we already deprecated we will have to cut breaking release with remove not but the change log should better indicate what is the change) WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
