Re: [PR] Add notes to the Trigger Dag UI form [airflow]

Tue, 10 Dec 2024 22:06:34 -0800 


jscheffl commented on code in PR #44822:
URL: https://github.com/apache/airflow/pull/44822#discussion_r1879399322


##########
airflow/ui/src/components/TriggerDag/TriggerDAGForm.tsx:
##########
@@ -204,6 +204,17 @@ const TriggerDAGForm: React.FC<TriggerDAGFormProps> = ({
                   </Box>
                 )}
               />
+
+              <Text fontSize="md" mb={2} mt={6}>
+                Notes

Review Comment:
   Can we make clear that this are not just "Any Notes" but "Dag Run Notes"?
   
   (If I correctly assume from view of legacy UI this refers to the notes as 
below?)
   
![image](https://github.com/user-attachments/assets/45d68394-d36c-461c-9ae1-acfbaf91cdfd)
   
   ```suggestion
                   Dag Run Notes
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to