yuqian90 commented on issue #6064: [AIRFLOW-5444] Fix action_logging so that request.form for POST is logged URL: https://github.com/apache/airflow/pull/6064#issuecomment-535375824 > This is fine, but it's just occurred to me that this might miss some actions entirely - ones that are using the Flask-AppBuilder model views etc. Thanks, @ashb. I looked at views.py again, most views inherit from `AirflowModelView` which is a subclass of `flask_appbuilder.ModelView`. Are those the views you think this action_logging decorator will miss? So I looked at some logs, I can confirm that actions such as `Airflow.graph`, `Airflow.clear`, `Airflow.delete` etc are all logged. So I believe the views using ModelView are not missed. Maybe I have misinterpreted what you meant? If that's the case pls point out. Also, what's the path from here? Can one of the committers help merge this PR now it's approved?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
