tirkarthi opened a new pull request, #44869:
URL: https://github.com/apache/airflow/pull/44869

   Add support to display XCom details for a task instance in a tab. Add a 
clipboard button next to the value so that user can copy the value easily. The 
PR also adds global XCom page under browse similar to Events page currently. 
   
   Notes for review and self : 
   
   1. Events page is at `src/pages/Events/` should I move this also to 
`src/pages/XCom` from current `airflow/ui/src/pages/TaskInstance/XCom` . I 
started with task instance and later realized it's easier to make this page 
global .
   2. Added `run_id` to the response for better filtering in retrieving value 
API in the global XCom page without any run id in the URL params.
   3. Each XCom entry needs an API call passing `stringify: true` to get the 
value. I have added a `skeleton` but is it possible to set some value to reuse 
the `Skeleton` from Table's component.
   4. Clipboard button was automatically generated from 
https://www.chakra-ui.com/docs/components/clipboard . Do I need to move these 
to individual files or disable the warnings?
   5. The value can be pretty printed and highlighted for JSON like legacy UI 
but can try it in another PR.
   
   ```
   
/home/karthikeyan/stuff/python/airflow/airflow/ui/src/components/ui/clipboard.tsx
      38:27  warning  Declare only one React component per file  
react/no-multi-comp
      47:31  warning  Declare only one React component per file  
react/no-multi-comp
      61:32  warning  Declare only one React component per file  
react/no-multi-comp
      72:30  warning  Declare only one React component per file  
react/no-multi-comp
      92:36  warning  Declare only one React component per file  
react/no-multi-comp
     104:31  warning  Declare only one React component per file  
react/no-multi-comp
   ```
   
   Related #44667 
   
   
![image](https://github.com/user-attachments/assets/dd3a73c6-8646-4274-a366-69aad7a153b4)
   
   
![image](https://github.com/user-attachments/assets/b8d67c65-c58d-4869-aad1-86104824ad4f)
   
   XCom under browse page
   
   
![image](https://github.com/user-attachments/assets/d291bb29-f160-4fd7-817b-84921401cc3b)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to