shubhamraj-git commented on code in PR #44850:
URL: https://github.com/apache/airflow/pull/44850#discussion_r1883288519
##########
airflow/ui/src/components/TriggerDag/TriggerDAGModal.tsx:
##########
@@ -94,12 +180,14 @@ const TriggerDAGModal: React.FC<TriggerDAGModalProps> = ({
<Dialog.CloseTrigger />
<Dialog.Body>
- <TriggerDAGForm
- dagParams={dagParams}
- onClose={onClose}
- onTrigger={handleTrigger}
- setDagParams={setDagParams}
- />
+ {Boolean(error) ? undefined : (
Review Comment:
This is failure fro dag details page, which eventually won't populate the
conf, which might be a problem for users, or mislead them, so thought to hide
it and stop from triggering. what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
