kaxil commented on PR #44322: URL: https://github.com/apache/airflow/pull/44322#issuecomment-2541552577
> I think there are a lot of hardcoded values, regexp and manual string manipulation etc. This code will likely break when the db version update the message or when a column name / values contains special character that we did not account for. The parsing could still fail. > > Also that's a lot of code to maintain, and it's not super welcoming. > > I'm not in favour of this change. > > I still think that at first just returning the plain `orig` and `statement` is enough for a user to understand. And for tests we just assert that those keys are present in the response. Yup, I agree, it looks too brittle unfortunately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
