gopidesupavan commented on code in PR #5: URL: https://github.com/apache/airflow-publish/pull/5#discussion_r1885699631
########## providers-release-config.yml: ########## @@ -0,0 +1,45 @@ +project: + name: airflow-publish + description: "Publish airflow packages to PyPI" +publisher: + name: airflow + url: https://dist.apache.org/repos/dist/dev/airflow + path: "providers/" +checks: + svn: + - id: extension + description: "Validate svn package extensions" + identifiers: + - type: regex + pattern: ".*(py3-none-any.whl|py3-none-any.whl.asc|py3-none-any.whl.sha512|tar.gz|tar.gz.asc|tar.gz.sha512)$" + + - id: package_name + description: "Validate svn package names" + identifiers: + - type: regex + pattern: ".*(apache_airflow_providers.*)$" + + checksum: + - id: checksum + description: "Validate check sum with SHA512" + algorithm: "sha512" + + signature: + - id: signature + description: "Validate signatures with GPG of packages" + method: gpg + keys: "https://dist.apache.org/repos/dist/release/airflow/KEYS"; + + publish: + id: publish + description: "Publish airflow providers packages to PyPI" + release-type: "RC_VERSION" Review Comment: Make sense, if there is no comparison required it makes more easy. This what i have view i am based on above context. For RC release the svn directory view, in side pypi-rc directory we will have the following files, and no files exists in inside providers directory? ``` dist/dev/airflow/providers/pypi-rc/ apache_airflow_providers_airbyte-4.0.0rc1-py3-none-any.whl.asc apache_airflow_providers_airbyte-4.0.0rc1-py3-none-any.whl.sha512 apache_airflow_providers_airbyte-4.0.0rc1-py3-none-any.whl apache_airflow_providers_airbyte-4.0.0rc1.tar.gz.asc ``` Post RC release, the files will be moved to providers directory and the pypi-rc directory will be empty or removed we dont care about it? only the providers directory files will be released to pypi? the view will be like below? ``` dist/dev/airflow/providers/ apache_airflow_providers_airbyte-4.0.0-py3-none-any.whl.asc apache_airflow_providers_airbyte-4.0.0-py3-none-any.whl.sha512 apache_airflow_providers_airbyte-4.0.0-py3-none-any.whl apache_airflow_providers_airbyte-4.0.0.tar.gz.asc ``` Everything we operate on the dev folder? For RC release the validations(checksum, signature, svn) would be performed on `dist/dev/airflow/providers/pypi-rc/`? Do we need to perform validations(checksum, signature, svn) for final release i.e from `dist/dev/airflow/providers/` ? Please correct me :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
