xBis7 commented on code in PR #43941:
URL: https://github.com/apache/airflow/pull/43941#discussion_r1886716534
##########
airflow/models/taskinstancehistory.py:
##########
@@ -83,6 +84,8 @@ class TaskInstanceHistory(Base):
executor_config = Column(ExecutorConfigType(pickler=dill))
updated_at = Column(UtcDateTime, default=timezone.utcnow,
onupdate=timezone.utcnow)
rendered_map_index = Column(String(250))
+ context_carrier = Column(MutableDict.as_mutable(ExtendedJSON))
+ span_status = Column(String(50), default=SpanStatus.NOT_STARTED)
Review Comment:
There is a pre-commit error if we don't add them
```
Check that TI and TIS have the same
attributes..............................Failed
- hook id: check-taskinstance-tis-attrs
- exit code: 1
Attributes in TaskInstance but not in TaskInstanceHistory:
{'context_carrier', 'span_status'}
Please make sure that the attributes are consistent across the classes.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
