ashb commented on code in PR #44972:
URL: https://github.com/apache/airflow/pull/44972#discussion_r1888714996
##########
airflow/dag_processing/manager.py:
##########
@@ -262,10 +258,8 @@ def terminate(self):
"""Send termination signal to DAG parsing processor manager to
terminate all DAG file processors."""
if self._process and self._process.is_alive():
self.log.info("Sending termination message to manager.")
- try:
-
self._parent_signal_conn.send(DagParsingSignal.TERMINATE_MANAGER)
- except ConnectionError:
- pass
+ self._parent_signal_conn.send(None)
+ self._parent_signal_conn.close()
Review Comment:
Ah yes we did. I'll add it back
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
