jscheffl commented on code in PR #44547:
URL: https://github.com/apache/airflow/pull/44547#discussion_r1888989835
##########
airflow/models/taskinstance.py:
##########
@@ -1127,7 +1127,8 @@ def _handle_failure(
)
if not test_mode:
- TaskInstance.save_to_db(failure_context["ti"], session)
+ task_instance.dag_run.refresh_from_db()
Review Comment:
Okay as I am not an expert in this area... used your DAG and the outcome is
mixed.
When I let the task "normal" fail, the call back executed once. If I
manually mark as fail the call back is executed two times - also with the patch
applied. So in my view it is not fixing the problem.
I tested with main and CeleryExecutor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
