o-nikolas opened a new pull request, #45016:
URL: https://github.com/apache/airflow/pull/45016

   ### PLEASE READ DESCRIPTION
   
   Context: In the context of multi team airflow, teams will have their own 
configuration files for the components that run on team-only hosts (for 
workers, dag parsers, etc running on those hosts). However some team components 
must live along side one another on the scheduler host, namely executors, and 
some airflow configuration affecting teams must also be accessible to the 
scheduler.
   
   This commit delivers the capability for airflow `conf` to load and allow 
access to multiple team configurations in addition to the main/global 
configuration we have today.
   
   A new config is added `core.multi_team_configurations` (the name is not set 
in stone) in which teams and their associated configuration files are 
specified. E.g.:
   ```
   path/to/team_a/config:team_a,different/path/team_b/configuration:team_b
   ```
   
   Airflow conf, during initialization, loads each of these configurations and 
makes them accessible by id, e.g.: `conf.get("core", "executor", 
team_id="team_a")`
   
   Within those team configurations, teams can specify the executors they would 
like to use and the associated configuration for those executors. Since each 
team configuration is loaded and stored separately, this allows multiple 
instances of the same executor to be configured.
   
   The Base executor has been updated with a config shim to allow easier access 
to team based executor configations and the AWS ECS executor has been updated 
to use it as a proof of concept. Other executors will need to be updated to be 
"multi team compliant" at a later time to minimize the size and scope of this 
commit.
   
   #### NOTE: There was an initial proposal to move to TOML format for Airflow 
config and store all configuration (both team and gloabl) in one file. This is 
still a possibility in the future, but the approach in this commit was decided 
for the following reasons:
   1. It leverages the same configuration format as Airflow always had, so 
there is less barrier to entry and migration for users
   2. It is a simpler implementation, which simplifies the overall process of 
releasing an initial version of multi-team airflow
   3. Separate files for teams is actually a nice mechanism for management of 
the overall cluster. Teams can update their own files as they see fit and they 
only need to be synced onto the scheduler host for pickup, rather than the 
configuration changes needing to be made to a shared file which no team should 
be able to view (otherwise they would see the configuration from other teams).
   
   <!--
    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
    distributed with this work for additional information
    regarding copyright ownership.  The ASF licenses this file
    to you under the Apache License, Version 2.0 (the
    "License"); you may not use this file except in compliance
    with the License.  You may obtain a copy of the License at
   
      http://www.apache.org/licenses/LICENSE-2.0
   
    Unless required by applicable law or agreed to in writing,
    software distributed under the License is distributed on an
    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    KIND, either express or implied.  See the License for the
    specific language governing permissions and limitations
    under the License.
    -->
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   
   
   <!-- Please keep an empty line above the dashes. -->
   ---
   **^ Add meaningful description above**
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a 
newsfragment file, named `{pr_number}.significant.rst` or 
`{issue_number}.significant.rst`, in 
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to