amoghrajesh commented on code in PR #44954:
URL: https://github.com/apache/airflow/pull/44954#discussion_r1889665056
##########
task_sdk/tests/execution_time/test_supervisor.py:
##########
@@ -862,6 +862,14 @@ def watched_subprocess(self, mocker):
"",
id="patch_task_instance_to_skipped",
),
+ pytest.param(
+ TaskState(state=TerminalTIState.FAILED,
end_date=timezone.parse("2024-10-31T12:00:00Z")),
+ b"",
+ "",
+ (),
+ "",
+ id="patch_task_instance_to_failed",
+ ),
Review Comment:
Yea that's true but I kept this change to be a little explicit about which
state it is going through explicitly. Would it be nice to just create a loop
inside params about this instead or nuke it entirely?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
