yovio-rca commented on code in PR #44963:
URL: https://github.com/apache/airflow/pull/44963#discussion_r1887111285
##########
chart/templates/triggerer/triggerer-kedaautoscaler.yaml:
##########
@@ -40,6 +40,7 @@ spec:
scaleTargetRef:
kind: {{ ternary "StatefulSet" "Deployment"
.Values.triggerer.persistence.enabled }}
name: {{ .Release.Name }}-triggerer
+ envSourceContainerName: {{ include "airflow.fullname" . }}-worker
Review Comment:
the container in my Trigerrer pod is just "triggerer"
##########
chart/templates/workers/worker-kedaautoscaler.yaml:
##########
@@ -39,6 +39,7 @@ spec:
scaleTargetRef:
kind: {{ ternary "StatefulSet" "Deployment"
.Values.workers.persistence.enabled }}
name: {{ include "airflow.fullname" . }}-worker
+ envSourceContainerName: {{ include "airflow.fullname" . }}-worker
Review Comment:
If you look at this file:
https://github.com/apache/airflow/blob/dbff6e325a9717b2b3f8b39e084034c68fbddfce/chart/templates/workers/worker-deployment.yaml#L232
The worker container is just hardcoded with value "worker"
##########
chart/templates/triggerer/triggerer-kedaautoscaler.yaml:
##########
@@ -40,6 +40,7 @@ spec:
scaleTargetRef:
kind: {{ ternary "StatefulSet" "Deployment"
.Values.triggerer.persistence.enabled }}
name: {{ .Release.Name }}-triggerer
+ envSourceContainerName: {{ include "airflow.fullname" . }}-worker
Review Comment:
Container name for trigerrer is always hardcode value:
https://github.com/apache/airflow/blob/dbff6e325a9717b2b3f8b39e084034c68fbddfce/chart/templates/triggerer/triggerer-deployment.yaml#L172
##########
chart/templates/workers/worker-kedaautoscaler.yaml:
##########
@@ -39,6 +39,7 @@ spec:
scaleTargetRef:
kind: {{ ternary "StatefulSet" "Deployment"
.Values.workers.persistence.enabled }}
name: {{ include "airflow.fullname" . }}-worker
+ envSourceContainerName: {{ include "airflow.fullname" . }}-worker
Review Comment:
Container name in my worker pod is just "worker" without any prefix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
