vincbeck commented on code in PR #45009:
URL: https://github.com/apache/airflow/pull/45009#discussion_r1890589167
##########
airflow/api_connexion/security.py:
##########
@@ -32,8 +32,8 @@
PoolDetails,
VariableDetails,
)
+from airflow.providers.fab.www.extensions.init_auth_manager import
get_auth_manager
Review Comment:
You are right. We should have only one, I updated the PR to only have one
auth manager across the different applications (fastapi application, legacy
Flask application and Flask application in the FAB provider). For both Flask
applications we need to pass the appbuilder to the auth manager but instead of
passing it as parameter to the constructor, I just set it like
`auth_manager.appbuilder = ...`. It is simpler that way. I also removed
`appbuilder` from the interface constructor.
Thanks for calling it out, it is definitely simpler and better that way!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
