jscheffl commented on code in PR #45045:
URL: https://github.com/apache/airflow/pull/45045#discussion_r1890655404
##########
airflow/ui/src/components/ClearRun/ClearRunButton.tsx:
##########
@@ -57,11 +66,12 @@ const ClearRunButton = ({ dagId, dagRunId }: Props) => {
requestBody: { dry_run: true, only_failed: onlyFailed },
});
}}
- variant="outline"
+ size={withText ? "md" : "sm"}
+ variant={withText ? "outline" : "ghost"}
>
- <FiRefreshCw height={5} width={5} />
- Clear Run
- </Button>
+ <FiRefreshCw />
+ {withText ? "Clear Run" : ""}
Review Comment:
If the button displays as icon, no text is there. Can you please add a
tooltip so that people can understand what the icon is for?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
