jedcunningham commented on code in PR #45088:
URL: https://github.com/apache/airflow/pull/45088#discussion_r1892962295
##########
airflow/dag_processing/collection.py:
##########
@@ -234,18 +233,15 @@ def _update_dag_warnings(
session.merge(warning_to_add)
-def _update_import_errors(
- files_parsed: set[str], import_errors: dict[str, str], processor_subdir:
str | None, session: Session
-):
+def _update_import_errors(files_parsed: set[str], import_errors: dict[str,
str], session: Session):
from airflow.listeners.listener import get_listener_manager
# We can remove anything from files parsed in this batch that doesn't have
an error. We need to remove old
# errors (i.e. from files that are removed) separately
session.execute(delete(ParseImportError).where(ParseImportError.filename.in_(list(files_parsed))))
- query =
select(ParseImportError.filename).where(ParseImportError.processor_subdir ==
processor_subdir)
- existing_import_error_files = set(session.scalars(query))
+ existing_import_error_files =
set(session.scalars(select(ParseImportError.filename)))
Review Comment:
I'm simply trying to break out parts to make it easier to review :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
