feluelle edited a comment on issue #5780: [AIRFLOW-5565] Add boto extraArgs to 
S3Hook load_bytes and load_file_obj
URL: https://github.com/apache/airflow/pull/5780#issuecomment-535984591
 
 
   Hey @maxcountryman, I created a [Jira 
Ticket](https://issues.apache.org/jira/browse/AIRFLOW-5565) for you.
   
   We currently do not test for the `extra_args` according to coverage of 
[load_bytes](https://codecov.io/gh/apache/airflow/src/master/airflow/hooks/S3_hook.py#L498)
 and 
[load_file_obj](https://codecov.io/gh/apache/airflow/src/master/airflow/hooks/S3_hook.py#L536)
 but I would greatly appreciate it if we do. Because otherwise your change is 
not guaranteed to work as you expect it to be in the future. :)
   
   Please update the commit message after you've added tests to include the 
Ticket Id. Thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to