kaxil commented on code in PR #45104:
URL: https://github.com/apache/airflow/pull/45104#discussion_r1893605182
##########
task_sdk/tests/execution_time/test_supervisor.py:
##########
@@ -772,7 +773,7 @@ def watched_subprocess(self, mocker):
),
pytest.param(
GetVariable(key="test_key"),
- b'{"key":"test_key","value":"test_value"}\n',
+
b'{"key":"test_key","value":"test_value","type":"VariableResult"}\n',
Review Comment:
Without the `type` field, the discriminator would fail.
https://github.com/apache/airflow/blob/bbaeedadf1f12ee70963dc9a6f790e9ed1af24b7/task_sdk/src/airflow/sdk/execution_time/task_runner.py#L167-L177
https://github.com/apache/airflow/blob/main/task_sdk/src/airflow/sdk/execution_time/comms.py#L107-L110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
