IlaiGigi opened a new pull request, #45133:
URL: https://github.com/apache/airflow/pull/45133

   This PR focuses on updating and formatting the contributors quick start 
guide.
   
   As a new experimenting contributor, I had some troubles when I worked with 
the quick start guide, some commands that didn't work because of outdated 
packages, some instructions were unclear etc.
   
   Addressing major changes I did:
   1. Moving down the installation of the `docker compose plugin`: If we 
already have a section that is dedicated to the installation of docker compose, 
then commands that are relevant to its installation should be there, and not in 
a section that is dedicated to the installation of purely docker.
   2. Sqlite -> sqlite3: according to the [Ubuntu package 
repository](https://packages.ubuntu.com/search?keywords=sqlite), the package 
`sqlite` is available only on `focal` and `jammy` Ubuntu distribution 
codenames. This means that the command `sudo apt install sqlite` will not work 
with any distributions beyond other than these two (like oracular, noble etc.). 
As I see it, these are the options:
   a. Move to `sqlite3`. This would require performing tests, which I have - 
ran all the tests under the ./tests directory, which is probably not sufficient.
   b. Add a note excluding distributions other than focal and jammy to use 
sqlite3 instead. This means developing on machines with distributions other 
than these may lead to inconsistencies as a result of breaking changes between 
the versions unless compatibility checks are done. 
   This is very likely larger than my PR, and the best course of action for now 
is probably to delay this change until a decision is made, I made the changes 
only to raise awareness.
   3. Removing section describing pre-commit with uv (lines 466-479): this 
content was just duplicated with the few lines below it. There are more 
examples of this behavior, but they are less aggressive so I decided to leave 
them be.
   
   The other changes I made are mostly cosmetic.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to